Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Need update dependency on intl-messageformat-parser to @formatjs/icu-messageformat-parser #3606

Open
Nicksqain opened this issue Mar 14, 2023 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file OSCI Open Source Contributor Initiative

Comments

@Nicksqain
Copy link
Contributor

Nicksqain commented Mar 14, 2023

Describe the bug

From investigation in #3027 (comment)

intl-messageformat-parser has been deprecated, so we need to update it to https://www.npmjs.com/package/@formatjs/icu-messageformat-parser.

To Reproduce
Steps to reproduce the behavior:

  1. Go to

src/dev/i18n/utils/verify_icu_message.ts

  1. Scroll down to
throw new parser.SyntaxError(
      'Unable to verify select format icu-syntax',
      'selectFormat',
      node.type,
      node.location
    );
  1. See error

OpenSearch Version
2.6.0

Dashboards Version
2.6.0

Screenshots

изображение

Host/Environment (please complete the following information):

  • OS: Windows

Additional context
#3027
!!! Check comment
#3027 (comment)

@Nicksqain Nicksqain added bug Something isn't working untriaged labels Mar 14, 2023
@AbhishekReddy1127 AbhishekReddy1127 added the OSCI Open Source Contributor Initiative label Mar 14, 2023
@joshuarrrr joshuarrrr added dependencies Pull requests that update a dependency file and removed bug Something isn't working untriaged labels Mar 15, 2023
@joshuarrrr joshuarrrr changed the title [CCI] Need update parser for @formatjs/icu-messageformat-parser [CCI] Need update dependency on intl-messageformat-parser to @formatjs/icu-messageformat-parser Mar 15, 2023
@joshuarrrr
Copy link
Member

@Nicksqain I updated this issue to focus on the dependency update/replacement we want to do here.

@joshuarrrr joshuarrrr removed their assignment Mar 15, 2023
@joshuarrrr
Copy link
Member

@Nicksqain Do you want this issue assigned, or should I mark it good first issue for someone else to pick up?

@Nicksqain
Copy link
Contributor Author

Nicksqain commented Mar 31, 2023

@Nicksqain Do you want this issue assigned, or should I mark it good first issue for someone else to pick up?

@joshuarrrr
Yes, assign me please, I want to know how it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file OSCI Open Source Contributor Initiative
Projects
None yet
Development

No branches or pull requests

3 participants