Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Visualization] [CCI] Remove custom styling for text-align:center in favor of OUI utility class oui-textCenter #4163

Closed
curq opened this issue May 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks

Comments

@curq
Copy link
Collaborator

curq commented May 29, 2023

Is your feature request related to a problem? Please describe.

As part of the OUI compliance audit, it was discovered that instead of OUI utility class, custom styling was used.

// Style for table component title
.visTable__component__title {
text-align: center;
}

Describe the solution you'd like

Use oui-textCenter instead.

Describe alternatives you've considered

Keep the custom styling, but it is not ideal.

Additional context

Audit from where the suggestions comes #4162.

@curq curq added the enhancement New feature or request label May 29, 2023
@curq curq changed the title [Table Visualization] [CCI] Remove custom styling for text-align: center in favor of OUI utility class oui-textCenter [Table Visualization] [CCI] Remove custom styling for text-align:center in favor of OUI utility class oui-textCenter May 29, 2023
@ananzh ananzh removed the untriaged label May 30, 2023
@joshuarrrr joshuarrrr added the OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks label Jun 1, 2023
@joshuarrrr joshuarrrr moved this to Done in Look & Feel Jun 7, 2023
@joshuarrrr
Copy link
Member

completed via #4164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks
Projects
Status: Done
Development

No branches or pull requests

3 participants