Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis colors] Update legacy seed colors to use ouiPaletteColorBlind() #4319

Closed
Tracked by #4318
joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Closed
Tracked by #4318

[Vis colors] Update legacy seed colors to use ouiPaletteColorBlind() #4319

joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Assignees
@manasvinibs
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 19, 2023 •
edited
Loading

Today, the tag cloud visualization in OpenSearch Dashboards gets its colors directly from https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/charts/public/services/colors/seed_colors.ts#L36-L4

Instead of a hard-coded list of seed colors, it should just call euiPaletteColorBlind() for the list of qualitative visualization colors. We should be able to remove the seed_colors file altogether as part of this fix.
@joshuarrrr joshuarrrr mentioned this issue Jun 19, 2023
Open
17 tasks
@joshuarrrr joshuarrrr added unified visualization UX OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks and removed untriaged labels Jun 19, 2023
@joshuarrrr joshuarrrr moved this to Todo in Look & Feel Jun 19, 2023
@manasvinibs manasvinibs mentioned this issue Jun 21, 2023
Merged
8 tasks
@joshuarrrr joshuarrrr moved this from Todo to In Progress in Look & Feel Jun 21, 2023
@joshuarrrr
Copy link
Member Author

fixed via #4348

@github-project-automation github-project-automation bot moved this from In Progress to Done in Look & Feel Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasvinibs manasvinibs

Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @manasvinibs