Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] visAugmenter requiring savedObjectsManagement puts other features at jeopardy #4671

Closed
AMoo-Miki opened this issue Aug 3, 2023 · 2 comments · Fixed by #4891
Closed
Assignees
Labels
bug Something isn't working v2.10.0

Comments

@AMoo-Miki
Copy link
Collaborator

Describe the bug

A lot of visualizations indicate that they require bundles from visAugmenter who requires bundles from savedObjectsManagement and that requires the management plugin. If the management plugin is disabled everything falls apart.

Ideally, visAugmenter should gracefully degrade by not requiring savedObjectsManagement and checking if it is available before doing

uiActions.addTriggerAction(SAVED_OBJECT_DELETE_TRIGGER, savedObjectDeleteAction);

To Reproduce
Steps to reproduce the behavior:

  1. Add management.enabled: false to the config
  2. Restart and access OSD

Expected behavior
Everything should work

OpenSearch Version
Any

Dashboards Version
2.9.0

Additional context

#4642

@joshuarrrr
Copy link
Member

joshuarrrr commented Aug 8, 2023

Part of the underlying root cause is that savedObjectManagement takes dependencies in the wrong direction - it should provide a registration function instead of taking dependencies on visualize, dashboard, discover: #1836

@ashwin-pc
Copy link
Member

This is actually a problem with the way UI Actions is built. The issue as seen in the screenshot is because the ui actions break the whole app when we try to register an action to a trigger that isnt registered. The saved object management plugin registers the trigger SAVED_OBJECT_DELETE_TRIGGER and the visAugmenter plugin binds to that trigger. Now when the saved object management plugin is disabled, the trigger is never registered and the visAugmenter plugin during startup throws an error when it tries to bind an action against a trigger that does not exist.

Screenshot 2023-08-31 at 3 48 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants