Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Query Categorization] Identifying the types of aggregations #11366

Closed
deshsidd opened this issue Nov 28, 2023 · 3 comments
Closed

[Search Query Categorization] Identifying the types of aggregations #11366

deshsidd opened this issue Nov 28, 2023 · 3 comments
Assignees
@deshsidd
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities Search:Query Insights Search Search query, autocomplete ...etc

Comments

@deshsidd
Copy link
Contributor

deshsidd commented Nov 28, 2023 •
edited
Loading

Identifying and documenting the types of aggregations applied and increment counters for the same.

As part of this task we will be incrementing counters for the various types of aggregations. We will be capturing this information for the following aggregations:

AdjacencyMatrixAggregation
CompositeAggregation
FilterAggregation
FiltersAggregation
GlobalAggregation
DateHistogramAggregation
HistogramAggregation
MissingAggregation
NestedAggregation
ReverseNestedAggregation
DateRangeAggregation
GeoDistanceAggregation
IpRangeAggregation
RangeAggregation
DiversifiedAggregation
SamplerAggregation
MultiTermsAggregation
SignificantTermsAggregation
SignificantTextAggregation
TermsAggregation
AvgAggregation
CardinalityAggregation
ExtendedStatsAggregation
GeoCentroidAggregation
MaxAggregation
MedianAbsoluteDeviationAggregation
MinAggregation
PercentileRanksAggregation
PercentilesAggregation
ScriptedMetricAggregation
StatsAggregation
SumAggregation
TopHitsAggregation
ValueCountAggregation
WeightedAvgAggregation

Note that we will be incrementing counters using the Telemetry metrics framework. We will have one counter for aggregations and each aggregation above will be incremented as a TYPE tag for this counter.

Phase 1: #10250
Phase 2 Meta issue : #11040
Query Visibility Roadmap : #11008
@deshsidd deshsidd added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 28, 2023
@deshsidd deshsidd self-assigned this Nov 28, 2023
@deshsidd deshsidd moved this from Todo to Now (This Quarter) in Performance Roadmap Nov 28, 2023
@peternied
Copy link
Member

Another example of this comment: #11367 (comment)

@deshsidd
Copy link
Contributor Author

deshsidd commented Dec 4, 2023

cc @getsaurabh02 @msfroh @backslasht Please provide some feedback.

@backslasht backslasht mentioned this issue Dec 5, 2023
Closed
@deshsidd deshsidd mentioned this issue Dec 11, 2023
Merged
8 tasks
@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In-Review in Performance Roadmap Dec 12, 2023
@deshsidd deshsidd mentioned this issue Dec 12, 2023
Open
@deshsidd deshsidd closed this as completed Jan 8, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jan 8, 2024
@github-project-automation github-project-automation bot moved this from In-Review to Done in Performance Roadmap Jan 8, 2024
@deshsidd
Copy link
Contributor Author

deshsidd commented Jan 8, 2024

Fixed by #11582 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deshsidd deshsidd

Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities Search:Query Insights Search Search query, autocomplete ...etc
Projects
Performance Roadmap
Status: Done
Search Project Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peternied @deshsidd