Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull Request Checks] Migrate pull request checks into a jenkinsfile #1504

Closed
peternied opened this issue Nov 4, 2021 · 4 comments
Closed
Labels
Build Libraries & Interfaces cicd enhancement Enhancement or improvement to existing feature or request

Comments

@peternied
Copy link
Member

Combine gradle precommit and checks into a single workflow. Then switch the jenkins job to use this file so pull request configuration is managed in this repository.

There is also room for improvement as the gradle precommit check can fail and when this happens the more intensive gradle check will also fail and maybe not provide useful results. Maybe there is a way to reduce resource usage or provide faster results.

@dblock
Copy link
Member

dblock commented Nov 4, 2021

The Jenkinsfile could live in this repo, too.

@dblock dblock added untriaged cicd enhancement Enhancement or improvement to existing feature or request labels Nov 4, 2021
@peterzhuamazon
Copy link
Member

Before we can resolve the issue where PR builder is able to run on pipeline this is not solvable at this point opensearch-project/opensearch-build#851

@peterzhuamazon
Copy link
Member

I dont want to introduce more issues by using precommit to trigger gradle check directly in freestyle.

@minalsha
Copy link
Contributor

minalsha commented Aug 2, 2022

Please reopen if this issue still persists. We have public Jenkins now and seems this should have been resolved. Thanks

@minalsha minalsha closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces cicd enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

5 participants