Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Merge to main tracking - Refactor InternalEngine to support Segrep specific Engine implementation. #3109

Closed
Tracked by #2355
mch2 opened this issue Apr 29, 2022 · 0 comments · Fixed by #3240
Assignees

Comments

@mch2
Copy link
Member

mch2 commented Apr 29, 2022

The current InternalEngine implementation wires up an IndexWriter to index into lucene and set merge policies. With segment replication we should not be wiring up a writer at all for replicas.

This issue involves refactoring the existing InternalEngine to extract needed functionality to write to the transaction log so that it can be reused inside of a segrep specific engine implementation.

The segrep engine should be able to write to the xlog when index() or delete() operations are invoked. It should also use a new OpenSearchReaderManager implementation that is similar to lucene's SegmentInfosSearcherManager that refreshes when new SegmentInfos are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant