Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zone Decommission]: Skip the drain timeout if the active request count is 0 #4721

Open
pranikum opened this issue Oct 10, 2022 · 1 comment
Assignees
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@pranikum
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As per discussion #4586 (comment)
It better to skip the node drain timeout if the request count is already 0. Call node stats API 2 times before the node drain timeout starts after the weights are set and after the timeout ends.

Currently we are only doing when the timeout ends.

Describe the solution you'd like
We can add a call to node stats API before the timeout schedule begin and if count is 0. We can directly call the decommission process.

Describe alternatives you've considered
NA

Additional context
NA

@pranikum pranikum added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 10, 2022
@pranikum pranikum changed the title Skip the drain timeout if the active request count is 0 [Recommission]: Skip the drain timeout if the active request count is 0 Oct 10, 2022
@pranikum pranikum changed the title [Recommission]: Skip the drain timeout if the active request count is 0 [Decommission]: Skip the drain timeout if the active request count is 0 Oct 10, 2022
@anasalkouz
Copy link
Member

@pranikum are you going to work on this issue as well?

@anasalkouz anasalkouz changed the title [Decommission]: Skip the drain timeout if the active request count is 0 [Zone Decommission]: Skip the drain timeout if the active request count is 0 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

3 participants