Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the IT test for the GeoTile and Geohash aggregations on GeoShape for Bounded use case. #6251

Closed
navneet1v opened this issue Feb 9, 2023 · 1 comment
Closed

Improving the IT test for the GeoTile and Geohash aggregations on GeoShape for Bounded use case. #6251

navneet1v opened this issue Feb 9, 2023 · 1 comment
Assignees
@navneet1v
Labels
Search:Aggregations :test Adding or fixing a test

Comments

@navneet1v
Copy link
Contributor

navneet1v commented Feb 9, 2023 •
edited
Loading

Description

This task aims to improve the Integration tests for the GeoTile and Geohash aggregations on GeoShape for Bounded use case. With this change: #6242 we are only testing the unbounded use cases for Aggregation on geoshapes, due to time constraints and failed CI builds.

As the GeoTile and Geohash aggregations on GeoShape feature is to be launched in 2.7 we have enough time to fix these tests. I will continue to work on fixing the test cases and meanwhile we can CIs can succeed.

Failed CI runs to be tested:

  1. https://build.ci.opensearch.org/job/gradle-check/10870/
  2. [BUG] GeoHashGridIT.testGeoShapes failure #6222

Commands to be tested:

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoHashGridIT.testGeoShapes" -Dtests.seed=5A3FA981D8815D0D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=zh-HK -Dtests.timezone=Pacific/Ponape -Druntime.java=19

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoHashGridIT.testGeoShapes" -Dtests.seed=5A3FA981D8815D0D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=zh-HK -Dtests.timezone=Pacific/Ponape

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoHashGridIT.testGeoShapes" -Dtests.seed=550C805789CC9374 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-JO -Dtests.timezone=Etc/GMT+7

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoHashGridIT.testGeoShapes" -Dtests.seed=550C805789CC9374 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-JO -Dtests.timezone=Etc/GMT+7
@navneet1v navneet1v added the enhancement Enhancement or improvement to existing feature or request label Feb 9, 2023
@navneet1v navneet1v self-assigned this Feb 9, 2023
@navneet1v navneet1v mentioned this issue Feb 9, 2023
Merged
6 tasks
@navneet1v navneet1v added :test Adding or fixing a test Search:Aggregations and removed enhancement Enhancement or improvement to existing feature or request labels Feb 9, 2023
@mch2 mch2 mentioned this issue Feb 10, 2023
Merged
6 tasks
@navneet1v
Copy link
Contributor Author

Resolving this issue, as code is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navneet1v navneet1v

Labels
Search:Aggregations :test Adding or fixing a test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navneet1v