Move zoom and coordinates as separate component #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 91.42% 91.28% -0.14%
==========================================
Files 11 12 +1
Lines 280 287 +7
Branches 37 39 +2
==========================================
+ Hits 256 262 +6
Misses 17 17
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junqiu-lei
reviewed
Mar 1, 2023
VijayanB
force-pushed
the
move-footer
branch
2 times, most recently
from
6f7c6c0 to
39d0c5d
Compare
We don't have to render zoom/coordiantes if there is no change in maps movement. Added unit test to check render Signed-off-by: Vijayan Balasubramanian <[email protected]>
junqiu-lei
approved these changes
Mar 1, 2023
martin-gaievski
approved these changes
Mar 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
We don't have to render zoom/coordiantes if there is no change in maps movement. Added unit test to check render Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 26aea7a)
VijayanB
pushed a commit
that referenced
this pull request
Mar 2, 2023
We don't have to render zoom/coordiantes if there is no change in maps movement. Added unit test to check render Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
pushed a commit
to VijayanB/dashboards-maps
that referenced
this pull request
Mar 20, 2023
…) (opensearch-project#311) We don't have to render zoom/coordiantes if there is no change in maps movement. Added unit test to check render Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 90acbc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move zoom and coordinates as separate component.
We don't have to render zoom/coordiantes if there is no change in maps movement.
Added unit test to check render
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.