Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listener on KeyUp #364

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

VijayanB
Copy link
Member

Description

Update esc key press check on key up.
Update popup information.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB VijayanB requested a review from a team March 29, 2023 06:23
Update esc key press check on key up.
Update popup information.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #364 (51f166b) into main (c5ee47a) will decrease coverage by 0.62%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   84.26%   83.64%   -0.62%     
==========================================
  Files          18       19       +1     
  Lines         464      477      +13     
  Branches       73       72       -1     
==========================================
+ Hits          391      399       +8     
- Misses         51       56       +5     
  Partials       22       22              

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VijayanB VijayanB merged commit 4fbd8b6 into opensearch-project:main Mar 29, 2023
@VijayanB VijayanB deleted the update-event branch March 29, 2023 17:51
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 29, 2023
Update esc key press check on key up.
Update popup information.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit 4fbd8b6)
VijayanB pushed a commit that referenced this pull request Mar 29, 2023
Update esc key press check on key up.
Update popup information.



Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants