-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(OUI Next Theme) Observability Notebooks #769
Comments
I think there may not be an issue here. The example in the screenshot shows a long string with no spaces. The right way to display it may in fact be to go beyond the text box. For example, the following string is force-wrapped to stay in the text box, but that means that a reader cannot tell how many contiguous X's are in the string and it appears like it has spaces when it doesn't. It's not clear to me that it's a better experience to force wrap a long string. xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx |
@wbeckler the other examples wrap and the user is able to consume the entire string. In this example I had to resize my browser beyond my monitors width multiple times to see the end. I would expect this to be scrollable if the case is that the wrapping is not desired. |
@pjfitzgibbons temporarily assigning to you until we figure out how to divide up these tasks - seems like a lot of OUI compliance issues coming our way |
@KrooshalUX could you show us an example of correct wrapping? Also, could you tell us where you found the example above? It might be a degenerate case ? |
@peternied The sample came from [Flights] OpenSearch SQL Quick Start Guide. Unfortunately, I no longer have access to this sample notebook. Previous sections in the notebook wrapped "correct" as in they did not break the container as the one in the screenshot does. |
@KrooshalUX (@pjfitzgibbons ) |
@pjfitzgibbons its no longer available on the endpoint where we were doing walkthroughs of the new theme, that is correct. @AMoo-Miki - do you have any additional info here? I would not say this is critical for 2.10 release. |
I am not sure I follow what @pjfitzgibbons is referring to when he says "wrapping requires spaces"; I believe a simple |
Welp. learn something every day. |
Fixed by #974 |
There's also an OUI utility class available for this:
https://oui.opensearch.org/1.0/#/utilities/css-utility-classes |
This issue to be transferred to corresponding repository
I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards
I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:
Screenshot taken from [Flights] OpenSearch SQL Quick Start Guide:
The text was updated successfully, but these errors were encountered: