Update notebooks snapshots and cypress #1367

ps48 · 2024-01-17T12:13:48Z

Description

Update notebooks snapshots and cypress

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 · 2024-01-18T07:44:53Z

Notebooks CI is fixed as seen here: https://github.com/ps48/dashboards-observability/actions/runs/7566656455/job/20604374203

The current CI failure are due to commits added in the main last PR and some upstream changes will create a separate PR to fix the CI changes.

Swiddis · 2024-01-18T18:47:18Z

.cypress/integration/notebooks_test/notebooks.spec.js

Does FTR also need these changes?

yes, the data-test-subjare re-used for FTR linked in there PR 1001 there.

Signed-off-by: Shenoy Pratik <[email protected]>

codecov · 2024-01-19T04:20:08Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (16ce008) 53.86% compared to head (fafa8db) 53.86%.

Files	Patch %	Lines
...oks/components/paragraph_components/paragraphs.tsx	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         316      316           
  Lines       11309    11309           
  Branches     2955     2955           
=======================================
  Hits         6092     6092           
  Misses       5169     5169           
  Partials       48       48

Flag	Coverage Δ
dashboards-observability	`53.86% <77.77%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paulstn · 2024-01-19T18:14:12Z

.cypress/integration/notebooks_test/notebooks.spec.js

@@ -31,10 +25,18 @@ const moveToPanelHome = () => {
  cy.visit(`${Cypress.env('opensearchDashboards')}/app/observability-dashboards#/`);
 };

+const moveToNotebookHome = () => {


moveToNotebookHome seems identical to moveToTestNotebook without the timeout, are they both necessary?

moveToNotebookHome -> Loads notebooks home page
moveToTestNotebook -> Loads the test notebook
Both are intended for different types of page loads.

paulstn · 2024-01-19T18:18:17Z

.cypress/integration/notebooks_test/notebooks.spec.js

+  before(() => {
+    moveToNotebookHome();
+    cy.get('a[data-test-subj="createNotebookPrimaryBtn"]').click();
+    cy.get('input[data-test-subj="custom-input-modal-input"]').focus().type(TEST_NOTEBOOK);


In the cypress documentation it says "It is unsafe to chain further commands that rely on the subject after .focus()" https://docs.cypress.io/api/commands/focus
It may not cause any issues but its worth keeping an eye on.

Make sense, this wasn't flaky when I tested it out on local with 20 runs. Without focus being called the type wouldn't work as expected. Will leave this one as is, let me know if you think this should be updated before merging in the PR.

IMO it doesn't need to be updated if it isn't causing issues, but it's definitely something to look at if further issues crop up.

* update notebooks cypress Signed-off-by: Shenoy Pratik <[email protected]> * update tests for query check Signed-off-by: Shenoy Pratik <[email protected]> * update ppl query check Signed-off-by: Shenoy Pratik <[email protected]> * fix detele notebooks, page reload issue Signed-off-by: Shenoy Pratik <[email protected]> * adding focus to inputs Signed-off-by: Shenoy Pratik <[email protected]> * move link check test at the end Signed-off-by: Shenoy Pratik <[email protected]> * fix focus for code input tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 8f1f83a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update notebooks snapshots and cypress (#1367) * update notebooks cypress Signed-off-by: Shenoy Pratik <[email protected]> * update tests for query check Signed-off-by: Shenoy Pratik <[email protected]> * update ppl query check Signed-off-by: Shenoy Pratik <[email protected]> * fix detele notebooks, page reload issue Signed-off-by: Shenoy Pratik <[email protected]> * adding focus to inputs Signed-off-by: Shenoy Pratik <[email protected]> * move link check test at the end Signed-off-by: Shenoy Pratik <[email protected]> * fix focus for code input tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 8f1f83a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * add wrapAll css Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <[email protected]>

* update notebooks cypress Signed-off-by: Shenoy Pratik <[email protected]> * update tests for query check Signed-off-by: Shenoy Pratik <[email protected]> * update ppl query check Signed-off-by: Shenoy Pratik <[email protected]> * fix detele notebooks, page reload issue Signed-off-by: Shenoy Pratik <[email protected]> * adding focus to inputs Signed-off-by: Shenoy Pratik <[email protected]> * move link check test at the end Signed-off-by: Shenoy Pratik <[email protected]> * fix focus for code input tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>

…ject#1375) * Update notebooks snapshots and cypress (opensearch-project#1367) * update notebooks cypress Signed-off-by: Shenoy Pratik <[email protected]> * update tests for query check Signed-off-by: Shenoy Pratik <[email protected]> * update ppl query check Signed-off-by: Shenoy Pratik <[email protected]> * fix detele notebooks, page reload issue Signed-off-by: Shenoy Pratik <[email protected]> * adding focus to inputs Signed-off-by: Shenoy Pratik <[email protected]> * move link check test at the end Signed-off-by: Shenoy Pratik <[email protected]> * fix focus for code input tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 8f1f83a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * add wrapAll css Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit 19cd16d)

ps48 requested review from pjfitzgibbons, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsimanohar, Swiddis, penghuo, seankao-az, anirudha, paulstn and sumukhswamy as code owners January 17, 2024 12:13

ps48 added the maintenance label Jan 17, 2024

ps48 force-pushed the notebooks_cypress_updates branch from ad393f9 to bd56a69 Compare January 18, 2024 06:24

ps48 added the backport 2.x label Jan 18, 2024

ps48 mentioned this pull request Jan 18, 2024

Update notebooks tests opensearch-project/opensearch-dashboards-functional-test#1001

Merged

1 task

RyanL1997 approved these changes Jan 18, 2024

View reviewed changes

Swiddis approved these changes Jan 18, 2024

View reviewed changes

ps48 added 7 commits January 18, 2024 20:07

update notebooks cypress

c6831aa

Signed-off-by: Shenoy Pratik <[email protected]>

update tests for query check

44379c0

Signed-off-by: Shenoy Pratik <[email protected]>

update ppl query check

5632740

Signed-off-by: Shenoy Pratik <[email protected]>

fix detele notebooks, page reload issue

a651291

Signed-off-by: Shenoy Pratik <[email protected]>

adding focus to inputs

612fd46

Signed-off-by: Shenoy Pratik <[email protected]>

move link check test at the end

0eb4e2a

Signed-off-by: Shenoy Pratik <[email protected]>

fix focus for code input tests

fafa8db

Signed-off-by: Shenoy Pratik <[email protected]>

ps48 force-pushed the notebooks_cypress_updates branch from ee01fa4 to fafa8db Compare January 19, 2024 04:07

paulstn reviewed Jan 19, 2024

View reviewed changes

paulstn self-requested a review January 19, 2024 18:56

paulstn approved these changes Jan 19, 2024

View reviewed changes

ps48 merged commit 8f1f83a into opensearch-project:main Jan 19, 2024
14 of 20 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 19, 2024

[Backport 2.x] Update notebooks snapshots and cypress #1375

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update notebooks snapshots and cypress #1367

Update notebooks snapshots and cypress #1367

ps48 commented Jan 17, 2024 •

edited

Loading

ps48 commented Jan 18, 2024

Swiddis Jan 18, 2024

ps48 Jan 18, 2024

codecov bot commented Jan 19, 2024

paulstn Jan 19, 2024

ps48 Jan 19, 2024

paulstn Jan 19, 2024

ps48 Jan 19, 2024

paulstn Jan 19, 2024

Update notebooks snapshots and cypress #1367

Update notebooks snapshots and cypress #1367

Conversation

ps48 commented Jan 17, 2024 • edited Loading

Description

Issues Resolved

Check List

ps48 commented Jan 18, 2024

Swiddis Jan 18, 2024

Choose a reason for hiding this comment

ps48 Jan 18, 2024

Choose a reason for hiding this comment

codecov bot commented Jan 19, 2024

Codecov Report

paulstn Jan 19, 2024

Choose a reason for hiding this comment

ps48 Jan 19, 2024

Choose a reason for hiding this comment

paulstn Jan 19, 2024

Choose a reason for hiding this comment

ps48 Jan 19, 2024

Choose a reason for hiding this comment

paulstn Jan 19, 2024

Choose a reason for hiding this comment

ps48 commented Jan 17, 2024 •

edited

Loading