Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rc1 qualifier reference #358

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

ps48
Copy link
Member

@ps48 ps48 commented May 10, 2022

Signed-off-by: Shenoy Pratik [email protected]

Description

Update build.gradle, package.json, dashboards.json from 2.0-rc1 to 2.0 release version

Issues Resolved

#356

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

@ps48 ps48 requested a review from a team as a code owner May 10, 2022 17:25
@ps48
Copy link
Member Author

ps48 commented May 10, 2022

Workflows fail due to dependency on Job-Scheduler 2.0 artifact. We can re-trigger the builds after the Job-Scheduler 2.0 artifact is available. Issue Tracker

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #358 (726ecd4) into main (56e9407) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #358   +/-   ##
=========================================
  Coverage     74.18%   74.18%           
  Complexity      383      383           
=========================================
  Files            94       94           
  Lines          3966     3966           
  Branches        639      639           
=========================================
  Hits           2942     2942           
  Misses          890      890           
  Partials        134      134           
Flag Coverage Δ
dashboards-reports 76.69% <ø> (ø)
reports-scheduler 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e9407...726ecd4. Read the comment docs.

@anirudha anirudha merged commit 38303cf into opensearch-project:main May 13, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-358-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 38303cf906dd38ac769cba29cdcceee86b457c72
# Push it to GitHub
git push --set-upstream origin backport/backport-358-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-358-to-2.0.

kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants