Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 1.x version increment process, remove dependency zips. #402

Closed
prudhvigodithi opened this issue Jun 30, 2022 · 2 comments
Closed
Assignees
Labels
enhancement New request infra Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jun 30, 2022

Is your feature request related to a problem?
The version increment PR's for 1.x requires job-scheduler zips to be part of src/test/resources/job-scheduler/ folder.
Sample PR:
https://github.com/opensearch-project/index-management/pull/374/files

What solution would you like?
Remove the injection of zip file via PR and use available latest URL to download the required zips
Example URL: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/latest/linux/x64/builds/opensearch/plugins/opensearch-job-scheduler-1.3.1.0.zip
This is already the case of version increments for 2.x the zips are not added as part of PR
Example 2.x version increment PR : https://github.com/opensearch-project/index-management/pull/377/files

What alternatives have you considered?
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/<version>/latest/linux/x64/builds/opensearch/plugins/<plugin name + version>.zip where <version> and plugin name parameter can be injected using gradle properties.

Do you have any additional context?
Committing a zip via a PR limits the capabilities to perform auto increment PR, more details on opensearch-project/opensearch-build#1375

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Jul 1, 2022

Hey @downsrob @praveensameneni can you please take a look at this feature proposed.
@bbarani

@downsrob downsrob added infra Changes to infrastructure, testing, CI/CD, pipelines, etc. and removed untriaged labels Jul 1, 2022
@downsrob downsrob self-assigned this Jul 1, 2022
@prudhvigodithi
Copy link
Member Author

Hey @downsrob can we close this issue as I see the PR #411 is merged.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New request infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

No branches or pull requests

2 participants