From 7ecb036a4ce11bdeaf055058cc972424663b60de Mon Sep 17 00:00:00 2001 From: John Mazanec Date: Thu, 6 Apr 2023 12:07:10 -0700 Subject: [PATCH] Fix corner case string format bug Signed-off-by: John Mazanec --- .../knn/plugin/action/RestSearchModelHandlerIT.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/opensearch/knn/plugin/action/RestSearchModelHandlerIT.java b/src/test/java/org/opensearch/knn/plugin/action/RestSearchModelHandlerIT.java index b82f27ca21..2bc36a7595 100644 --- a/src/test/java/org/opensearch/knn/plugin/action/RestSearchModelHandlerIT.java +++ b/src/test/java/org/opensearch/knn/plugin/action/RestSearchModelHandlerIT.java @@ -87,11 +87,15 @@ public void testSizeValidationFailsInvalidSize() throws IOException { Request request = new Request("GET", restURI); ResponseException ex = expectThrows(ResponseException.class, () -> client().performRequest(request)); + String messageExpected = String.format( + "%s must be between %s and %s inclusive", + PARAM_SIZE, + SEARCH_MODEL_MIN_SIZE, + SEARCH_MODEL_MAX_SIZE + ); assertTrue( - ex.getMessage() - .contains( - String.format("%s must be between %d and %d inclusive", PARAM_SIZE, SEARCH_MODEL_MIN_SIZE, SEARCH_MODEL_MAX_SIZE) - ) + String.format("FAILED - Expected \"%s\" to have \"%s\"", ex.getMessage(), messageExpected), + ex.getMessage().contains(messageExpected) ); }