Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client setting to ignore warning exceptions #850

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Add client setting to ignore warning exceptions #850

merged 2 commits into from
Apr 10, 2023

Conversation

martin-gaievski
Copy link
Member

Description

Fixing integ test, when running in secure cluster it produces WarningException like below. For tests we can ignore such warnings, there is a setting for rest client that needs to be enabled

java.lang.AssertionError: Exception not expected as valid index arguements passed: org.opensearch.client.WarningFailureException: method [PUT], host [https://localhost:9200/], URI [/test_index], status line [HTTP/1.1 200 OK]

    Warnings: [[index.knn.algo_param.ef_construction] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.]

    {"acknowledged":true,"shards_acknowledged":true,"index":"test_index"}

        at __randomizedtesting.SeedInfo.seed([B9031256349BA03A:D1B6ED99033EDC32]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.opensearch.knn.index.NmslibIT.testCreateIndexWithValidAlgoParams_settings(NmslibIT.java:177)

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 2.x backport 2.7 labels Apr 8, 2023
@martin-gaievski martin-gaievski requested a review from a team April 8, 2023 00:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023 •
edited
Loading

Codecov Report

Merging #850 (d5d766c) into main (1b6fd48) will decrease coverage by 0.25%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #850      +/-   ##
============================================
- Coverage     85.42%   85.17%   -0.25%     
+ Complexity     1091     1086       -5     
============================================
  Files           152      152              
  Lines          4404     4404              
  Branches        393      393              
============================================
- Hits           3762     3751      -11     
- Misses          465      474       +9     
- Partials        177      179       +2

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martin-gaievski martin-gaievski force-pushed the fix-warning-exception-in-integ-test branch from 1566b28 to c87f7c5 Compare April 8, 2023 01:41
@navneet1v
Copy link
Collaborator

The build gha js failing for ubnutu. @martin-gaievski please check.

@martin-gaievski
Copy link
Member Author

The build gha js failing for ubnutu. @martin-gaievski please check.

worker failed with native outofmemory, works after restart. please check again @navneet1v

@martin-gaievski martin-gaievski merged commit d63f5b0 into opensearch-project:main Apr 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
@martin-gaievski @github-actions
Add client setting to ignore warning exceptions (#850)
76911e6 
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d63f5b0)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
@martin-gaievski @github-actions
Add client setting to ignore warning exceptions (#850)
9fa4d29 
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d63f5b0)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 10, 2023
Merged
martin-gaievski added a commit that referenced this pull request Apr 10, 2023
@opensearch-trigger-bot @martin-gaievski
Add client setting to ignore warning exceptions (#850) (#852)
b0de90f 
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d63f5b0)

Co-authored-by: Martin Gaievski <[email protected]>
martin-gaievski added a commit that referenced this pull request Apr 10, 2023
@opensearch-trigger-bot @martin-gaievski
Add client setting to ignore warning exceptions (#850) (#851)
e004079 
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit d63f5b0)

Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navneet1v navneet1v navneet1v approved these changes

@naveentatikonda naveentatikonda naveentatikonda approved these changes

Assignees
No one assigned
Labels
backport 2.x backport 2.7 Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-gaievski @codecov-commenter @navneet1v @naveentatikonda