Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Retry Stratergy while interacting with ML Commons Predict API #431

Closed
navneet1v opened this issue Oct 10, 2023 · 0 comments · Fixed by #1054
Closed

Improve Retry Stratergy while interacting with ML Commons Predict API #431

navneet1v opened this issue Oct 10, 2023 · 0 comments · Fixed by #1054
Assignees
Labels
Enhancements Increases software capabilities beyond original client specifications help wanted Extra attention is needed

Comments

@navneet1v
Copy link
Collaborator

navneet1v commented Oct 10, 2023

Description

The current while interacting with ML Commons is very simple, we retry 3 times and then fail the request. This is very naive and doesn't scale well with remote models that can have quotas or rate limiting enabled.

https://github.com/opensearch-project/neural-search/blob/main/src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java#L116-L134

Solution

Come up with a better retry strategy while interacting with ML Commons Predict API to improve the user experience. Some of the strategies can be:

  1. Exponential backoff
  2. Token Bucket Retries
    etc.
@navneet1v navneet1v added the Enhancements Increases software capabilities beyond original client specifications label Oct 10, 2023
@navneet1v navneet1v moved this from Backlog to Backlog (Hot) in Vector Search RoadMap Oct 10, 2023
@navneet1v navneet1v added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Oct 30, 2023
@github-project-automation github-project-automation bot moved this from Backlog (Hot) to ✅ Done in Vector Search RoadMap Jan 4, 2025
@heemin32 heemin32 moved this from 2.19 to Done in Neural Search RoadMap Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants