Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NeuralQueryEnricher search processor is not working with NestedQuery #813

Closed
IanMenendez opened this issue Jul 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@IanMenendez
Copy link
Contributor

NeuralQueryEnricher search processor is not working with NestedQueries

how to reproduce:

PUT /_search/pipeline/test_pipeline 
{
  "request_processors": [
    {
      "neural_query_enricher" : {
        "default_model_id": "u5j0qYoBMtvQlfhaxOsa",
        "neural_field_default_id": {
           "embedding_field.knn": "uZj0qYoBMtvQlfhaYeud"
        }
      }
    }
  ]
}

GET testindex/_search?search_pipeline=test_pipeline
{
  "query": {
    "nested": {
      "score_mode": "max",
      "path": "passage_chunk_embedding",
      "query": {
        "neural": {
          "embedding_field.knn": {
            "query_text": "document"
          }
        }
      }
    }
  }
}

This should work but instead throws:

{
  "error": {
    "root_cause": [
      {
        "type": "null_pointer_exception",
        "reason": "modelId is marked non-null but is null"
      }
    ],
    "type": "null_pointer_exception",
    "reason": "modelId is marked non-null but is null"
  },
  "status": 500
}
@navneet1v
Copy link
Collaborator

@zhichao-aws where are we on fixing the bug?

@zhichao-aws
Copy link
Member

@zhichao-aws where are we on fixing the bug?

it's complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants