Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation workflow] Support both docker and ECR as image source for container images validation #4756

Closed
gaiksaya opened this issue Jun 10, 2024 · 1 comment
Closed

[Validation workflow] Support both docker and ECR as image source for container images validation #4756

gaiksaya opened this issue Jun 10, 2024 · 1 comment
Assignees
@Divyaasm
Labels
enhancement New Enhancement

Comments

@gaiksaya
Copy link
Member

Is your feature request related to a problem? Please describe

Currently the jenkins (as well as python workflow) provides docker validation with either Dockerhub OR ECR but not both.
With #4750, it would be great if we can validate both in one go rather than triggering the job twice. The job params are pretty confusing too as a lot of validations happens together.

Describe the solution you'd like

Give an option as

  • Dockerhub
  • ECR
  • Both

Describe alternatives you've considered

Keep triggering twice. :(

Additional context

No response
@gaiksaya gaiksaya added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jun 10, 2024
@Divyaasm Divyaasm removed the untriaged Issues that have not yet been triaged label Jun 11, 2024
@Divyaasm Divyaasm self-assigned this Jun 11, 2024
@Divyaasm Divyaasm moved this from Backlog to In Progress in OpenSearch Engineering Effectiveness Jun 11, 2024
@Divyaasm Divyaasm mentioned this issue Jun 11, 2024
Merged
@Divyaasm Divyaasm moved this from In Progress to Done in OpenSearch Engineering Effectiveness Jun 12, 2024
@Divyaasm
Copy link
Collaborator

Closed via #4762

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Engineering Effectiveness Board Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Divyaasm Divyaasm

Labels
enhancement New Enhancement
Projects
Engineering Effectiveness Board
Status: ✅ Done
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaiksaya @Divyaasm