Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI component update) Update behavior of OuiComboBox with single selection #137

Closed
xeniatup opened this issue Nov 29, 2022 · 4 comments
Closed
Labels

Comments

@xeniatup
Copy link

OuiComboBox component with singleSelection prop applied appears to be editable as the cursor stays present after selection is made.
Although the selection isn't editable, a user could press backspace to delete the selection from the box. The element seems to use that behavior regardless of how its singleSelection and isClearable settings are configured. It doesn't appear that we have a means of removing the cursor in the component.

Describe the solution you'd like

Hide the cursor when selection is made.

Describe alternatives you've considered

@AWSHurneyt researched the ways to remove the cursor using the current implementation of the component.

Additional context
Originating from this issue: opensearch-project/alerting-dashboards-plugin#257

ezgif com-gif-maker (4)

@KrooshalUX
Copy link
Contributor

@xeniatup can you give some insight into the "why" of why you would like to remove this cursor.

In the case of a single selection, the cursor remains in the input box and the user can still utilize the search bar to quickly replace the value or to clear the value using back space (as per your line "...a user could press backspace to delete the selection from the box.").

Removing the cursor has deep implications in usability and accessibility for those who interact with the interface primarily via keyboard. It would also impact the interaction across all components utilizing the ComboBox primitive.

isClearable controls if the X appears to quickly clear the selection, not if the element is immutable or not.

@kgcreative
Copy link
Member

I believe the cursor is intended behavior as that's what allows for searching the drop down if you want to change your selection

@KrooshalUX
Copy link
Contributor

@kgcreative Are you good with us closing this with "not planned"?`

@kgcreative
Copy link
Member

I'm ok closing as "won't fix"

@KrooshalUX KrooshalUX closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants