Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchable prop to SuperSelect #51

Closed
ashwin-pc opened this issue Aug 29, 2022 · 6 comments
Closed

Add searchable prop to SuperSelect #51

ashwin-pc opened this issue Aug 29, 2022 · 6 comments

Comments

@ashwin-pc
Copy link
Member

Currently the Datasource picker for the Drag and Drop editor in OpenSearch Dashboards is a custom built component since the SuperSelect prop does not provide the option to filter the options. Add a filter or searchable prop to SuperSelect to allow it to replace the custom Datasource picker.

Screen Shot 2022-08-29 at 4 04 00 PM

@ashwin-pc
Copy link
Member Author

@KrooshalUX @kgcreative Have we prioritized this? Looks like this is the defacto Datasource selector for many new UI's. e.g. the Maps plugin. Have we prioritized this?

@kgcreative
Copy link
Member

kgcreative commented Oct 20, 2022

If we haven't, we should. Let's dig into this sooner rather than later. I think we're also using this for PIT

@kgcreative
Copy link
Member

@ashwin-pc -- @KrooshalUX will respond with some thoughts that wouldn't require us to modify SuperSelect.

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Oct 25, 2022

OUI offers many solutions to selecting objects and making choices. While the OUI team works to improve documentation and guidance on choosing components, my main concern is adding search prop option to OuiSuperSelect increases the difficulty of decision making because there are already other components for drop-down like choice behavior that include search. OuiSuperSelect should remain reserved for use cases involving a small amount of choices (fewer than 9 options , aka "the 7 + or -2 rule").

The more appropriate choice would be to utilize OuiSelectable which has a searchable prop already. This UI is more suited for a long list of choices, and also offers the flexibility of limiting to allow the user to make a single or multiple choices within the menu and having options excluded when the case is appropriate. Placed in a popover, this should perform the function of a "searchable dropdown" you are looking for.

@KrooshalUX
Copy link
Contributor

@ashwin-pc you may also want to look into OuiFilterSelectItem, which is a composed version of Selectable & Search within a pop-over. I am considering renaming this component to surface it up for use beyond Filter Group.

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Oct 25, 2022

Further conversation and design review lead @ashwin-pc and I to identify using OuiComboBox with single selection & setting isClearable to false. OuiComboBox has search implemented out of the box, but could use some touch ups to prevent user errors (@ashwin-pc found that a user can type an incomplete entry without a match unlike OuiFilterSelectItem).

The path forward for projects in flight would be for @ashwin-pc to add a minimal amount of customization to the implementation of OuiComboBox to limit user errors while the OUI team works to tighten up this interaction and prepare the change for release in a next OUI version. That can be tracked here:#95

Closing this as no action will be taken on SuperSelect at this time.

@KrooshalUX KrooshalUX moved this to Icebox (No Dev) in OUI Components Nov 1, 2022
@KrooshalUX KrooshalUX moved this from Icebox (No Dev) to Done (All Sprints) in OUI Components Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants