Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to icon pack #628

Closed
8 tasks
KrooshalUX opened this issue Mar 23, 2023 · 7 comments · Fixed by #658
Closed
8 tasks

Add icons to icon pack #628

KrooshalUX opened this issue Mar 23, 2023 · 7 comments · Fixed by #658
Assignees

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Mar 23, 2023

This issue supports OSD release 2.7

The following icons need to be added to OUI & the OUI documentation website - retain the alphabetical order of the Glyphs list.

Use these guidelines for design and adding icons to OUI : https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style

@KrooshalUX
Copy link
Contributor Author

visBuilder
visBuilderDQL
visBuilderPPL
visBuilderPromQL
visBuilderSavedObject
visBuilderSQL

@KrooshalUX KrooshalUX removed the blocked label Apr 1, 2023
@KrooshalUX
Copy link
Contributor Author

@BSFishy all icons for the 1.1 release are here in the comments. Please refer to https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style on next steps

@canascar
Copy link
Member

canascar commented Apr 1, 2023

polygon
radius

@opensearch-project opensearch-project deleted a comment from canascar Apr 3, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Apr 4, 2023

I did some cleanup to the final SVG files:

  1. Add SPDX header
  2. Indent paths
  3. Remove fills on paths
  4. Re-order svg tag
  5. Remove fill on svg tag

(for reference)

@KrooshalUX
Copy link
Contributor Author

Thanks @BSFishy - wondering if we should use that to update anything on this doc: https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style - I think earlier you mentioned you had some ideas.

Also for SOP-ifying this: I would like to keep UX out of preparing the files beyond the original export, in case a mistake is made while editing. Otherwise, engineering would need to wait for UX to re-export, this way engineering has the original export and can modify as necessary with less likelihood of errors.

@BSFishy
Copy link
Contributor

BSFishy commented Apr 4, 2023

Thanks @BSFishy - wondering if we should use that to update anything on this doc: https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style - I think earlier you mentioned you had some ideas.

I think it is mostly covered in the Clean the SVG section. I can submit a PR to update it with more detailed info from what I did for these icons.

Also for SOP-ifying this: I would like to keep UX out of preparing the files beyond the original export, in case a mistake is made while editing. Otherwise, engineering would need to wait for UX to re-export, this way engineering has the original export and can modify as necessary with less likelihood of errors.

I agree. I wanted to update this issue for knowledge sharing reasons for the future.

@KrooshalUX
Copy link
Contributor Author

Updated names as per feedback from pull request #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants