-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to icon pack #628
Comments
@BSFishy all icons for the 1.1 release are here in the comments. Please refer to https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style on next steps |
I did some cleanup to the final SVG files:
(for reference) |
Thanks @BSFishy - wondering if we should use that to update anything on this doc: https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style - I think earlier you mentioned you had some ideas. Also for SOP-ifying this: I would like to keep UX out of preparing the files beyond the original export, in case a mistake is made while editing. Otherwise, engineering would need to wait for UX to re-export, this way engineering has the original export and can modify as necessary with less likelihood of errors. |
I think it is mostly covered in the Clean the SVG section. I can submit a PR to update it with more detailed info from what I did for these icons.
I agree. I wanted to update this issue for knowledge sharing reasons for the future. |
Updated names as per feedback from pull request #658 |
This issue supports OSD release 2.7
The following icons need to be added to OUI & the OUI documentation website - retain the alphabetical order of the Glyphs list.
Use these guidelines for design and adding icons to OUI : https://github.com/opensearch-project/oui/blob/main/wiki/creating-icons.md#style
The text was updated successfully, but these errors were encountered: