Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds field mappings to edit detector pages #490

Merged
merged 15 commits into from
Apr 4, 2023

Conversation

jovancacvetkovic
Copy link

@jovancacvetkovic jovancacvetkovic commented Mar 22, 2023

Description

This feature adds field mappings to edit detector details and edit detector rules.
Field mappings will appear if the data source or any rule selection is changed.

Screenshots

automatically mapped
needs manual mapping

Mocks

edit detector details
edit detector rules

Issues Resolved

Resolves #482

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jovancacvetkovic jovancacvetkovic requested a review from a team March 22, 2023 15:28
…-analytics-dashboards-plugin into edit_detector_ux

# Conflicts:
#	public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx
#	public/pages/Detectors/components/UpdateRules/UpdateRules.tsx
#	public/pages/Detectors/containers/FieldMappings/EditFieldMapping.tsx
#	public/pages/Detectors/containers/FieldMappings/__snapshots__/EditFieldMappings.test.tsx.snap
Copy link
Collaborator

@amsiglan amsiglan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@amsiglan amsiglan merged commit bb277ae into opensearch-project:main Apr 4, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2023
* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)
amsiglan pushed a commit that referenced this pull request Apr 6, 2023
* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…pensearch-project#500)

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing opensearch-project#487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit detector - UX improvements and updates
4 participants