[BUG] Fixes few minor UX bugs #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]>
…arch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #525 +/- ##
=======================================
Coverage 35.59% 35.59%
=======================================
Files 121 121
Lines 3444 3444
Branches 602 602
=======================================
Hits 1226 1226
Misses 2081 2081
Partials 137 137 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
amsiglan
approved these changes
Apr 18, 2023
AWSHurneyt
approved these changes
Apr 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
* [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f1be08e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
* [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f1be08e)
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
* [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
added a commit
that referenced
this pull request
Apr 18, 2023
* Minor bug fixes (#505) * [BUG] Edit details Save button should be blue #499 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * [BUG] Fixes few minor UX bugs (#525) * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515) * Update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Minor bug fixes (#505) * [BUG] Edit details Save button should be blue #499 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * [BUG] Fixes few minor UX bugs (#525) * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515) * Update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit d0b1702)
AWSHurneyt
added a commit
that referenced
this pull request
Apr 18, 2023
* Minor bug fixes (#505) * [BUG] Edit details Save button should be blue #499 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling #496 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * [BUG] Fixes few minor UX bugs (#525) * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515) * Update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit d0b1702) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
* Minor bug fixes (opensearch-project#505) * [BUG] Edit details Save button should be blue opensearch-project#499 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling opensearch-project#496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling opensearch-project#496 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detector details has some bad text handling opensearch-project#496 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * [BUG] Fixes few minor UX bugs (opensearch-project#525) * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (opensearch-project#515) * Update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few minor UX bugs:
Issues Resolved
Resolves #522
Resolves #521
Resolves #520
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.