Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Tenant feature with the removal of tiny amazon links #1439

Merged

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented May 25, 2023

Description

Manual backport tenant feature with the removal of tiny amazon links since there is not option of rebase for autobot's backporting PRs.

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
New Feature

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

abhivka7 and others added 2 commits May 25, 2023 11:53
* Dynamic multitenancy feature.

Signed-off-by: Abhi Kalra <[email protected]>

* Dynamic multitenancy feature -PR feedback

Signed-off-by: Abhi Kalra <[email protected]>

---------

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
@RyanL1997 RyanL1997 changed the title Manual backport tenant feature with the removal of tiny amazon links [Manual backport 2.x] Tenant feature with the removal of tiny amazon links May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1439 (99f33e5) into 2.x (8fe290b) will decrease coverage by 6.16%.
The diff coverage is 36.06%.

@@            Coverage Diff             @@
##              2.x    #1439      +/-   ##
==========================================
- Coverage   71.67%   65.51%   -6.16%     
==========================================
  Files          88       93       +5     
  Lines        2037     2294     +257     
  Branches      277      312      +35     
==========================================
+ Hits         1460     1503      +43     
- Misses        511      723     +212     
- Partials       66       68       +2     
Impacted Files Coverage Δ
public/apps/configuration/app-router.tsx 11.66% <0.00%> (+6.40%) ⬆️
public/apps/configuration/panels/get-started.tsx 76.92% <0.00%> (-13.99%) ⬇️
...s/configuration/panels/tenant-list/tenant-list.tsx 0.00% <0.00%> (-82.36%) ⬇️
public/apps/configuration/utils/request-utils.ts 8.69% <0.00%> (-0.83%) ⬇️
...c/apps/configuration/utils/tenancy-config_util.tsx 0.00% <0.00%> (ø)
public/apps/configuration/utils/toast-utils.tsx 72.72% <0.00%> (-27.28%) ⬇️
public/utils/dashboards-info-utils.tsx 0.00% <0.00%> (ø)
...onfiguration/panels/tenant-list/configure_tab1.tsx 7.84% <7.84%> (ø)
...guration/panels/tenant-list/save_changes_modal.tsx 14.28% <14.28%> (ø)
public/apps/configuration/utils/tenant-utils.tsx 67.90% <40.00%> (-2.99%) ⬇️
... and 6 more

@RyanL1997
Copy link
Collaborator Author

Pretty sure we should ignore these codecov failures.

@cwperks cwperks merged commit 1983313 into opensearch-project:2.x May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants