Addressing spelling mistakes in server code. #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Houston <[email protected]>
shoustech
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
There was a problem hiding this comment.
Thank you @shoustech for this contribution to improve readability. Left 1 nit, otherwise looks good.
Signed-off-by: Shawn Houston <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 94 94
Lines 2404 2404
Branches 318 318
=======================================
Hits 1613 1613
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
cwperks
approved these changes
Jan 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Addressing spelling mistakes in server code. Signed-off-by: Shawn Houston <[email protected]> * Corrected cammel case of renamed variable. Signed-off-by: Shawn Houston <[email protected]> --------- Signed-off-by: Shawn Houston <[email protected]> (cherry picked from commit f854cb3)
cwperks
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Addressing spelling mistakes in server code. Signed-off-by: Shawn Houston <[email protected]> * Corrected cammel case of renamed variable. Signed-off-by: Shawn Houston <[email protected]> --------- Signed-off-by: Shawn Houston <[email protected]> (cherry picked from commit f854cb3) Co-authored-by: Shawn Houston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrected spelling mistakes in variables found in the
server/folder code. I also addressed some spelling mistakes in comments when I saw them but they were not a priority.Category
[Bug fix]
Why these changes are required?
Having mis-spelt variables in a set of code can cause bugs during development and should be fixed when possible. This is more a preventative PR more than anything else.
What is the old behavior before changes and new behavior after changes?
There are not any changes in the code before or after changes.
Issues Resolved
#1740
Testing
There has not been any testing outside of reviewing the changes before committing.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.