-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Create dynamic configuration section in config.yml for extensions #2615
Comments
Why not add this in the
|
Why does an Admin need to be able to provide there own key? What do you think about the security plugin manage the generation on its own, and supply an API to rotate the keys? "Extensions needs this feature" doesn't translate to the feature name needs to include the work extensions. To me this is the DelegatingAuthenticationBackend - but I'm happy to consider other names. |
[Triage] This is part of the Extensions project. |
Hi, |
Hi @MaciejMierzwa, sorry I did not reply earlier I was on vacation from Wednesday to Friday last week. The only remaining decision for this task is whether to name the new section of the config
i.e. If a cluster is using the internal users list, all internal users are stored in this index. If the cluster admin creates a new internal user what happens is that the security index is updated to add a new user into the users area of the configuration and all nodes are instructed to reload their configuration from the index. Dynamic means settings that are changeable without a reboot opposed to settings defined in |
I agree on naming @cwperks. So far I have pushed my changes into: https://github.com/MaciejMierzwa/security/tree/extensions_config |
Thank you @MaciejMierzwa, I think A couple of names that may be suitable:
Can you open up a PR to solicit comments? |
Closing this one as related PR has been merged. |
For the initial experimental release of extensions, the security plugin needs to support a couple dynamic configuration options to support the issuance and verification of auth tokens. All configuration options should fall under a new key in the
config.dynamic
portion of the security pluginconfig.yml
file. Below is an example of the dynamic configuration options.The 2 configuration options above represent 2 initial options needed to support the auth token workflows, but this
extensions:
area of the config.yml file may be extended in the future with more dynamic configuration options.The 2 settings above represent:
signing_key
- This is a base64 encoded secret that will be used to create a JWK to sign the JWTs that are issued - by default the signing is done using symmetric encryption (HMAC SHA512). More configurable keys will be supported in the future, but the default is chosen for the experimental release.encryption_key
- This is another base64 encoded secret, but this will be utilized to encrypt sensitive information in the payload of the JWT.signing_key
andencryption_key
are also utilized for an authentication backend to support these tokens issued by the security plugin and used to verify the tokens and decrypt the encrypted sections of the payload.There are 2 java files around config in this codebase: ConfigV6 and ConfigV7. This change will only support OS >=2 so changes can be only applied into ConfigV7.
The text was updated successfully, but these errors were encountered: