Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tests to verify changes to default admin credentials #3636

Closed
5 tasks done
Tracked by #3622
DarshitChanpura opened this issue Nov 1, 2023 · 1 comment · Fixed by #3807
Closed
5 tasks done
Tracked by #3622

Implement tests to verify changes to default admin credentials #3636

DarshitChanpura opened this issue Nov 1, 2023 · 1 comment · Fixed by #3807
Assignees
@DarshitChanpura
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Nov 1, 2023 •
edited
Loading

Description:

With the completion of the changes to extract the demo configuration script into a Java tool, it is crucial to add tests to validate and ensure the accuracy of these changes. This GitHub issue is dedicated to the task of incorporating tests that will guarantee the new functionality works as expected.

Acceptance Criteria

  • Add tests to ensure that demo certificate files are created
  • Add tests to ensure that the script accepts a custom password
  • Add tests to ensure that the script generates a new password if one is not provided
  • Add test to ensure that a call to the cluster with admin:admin fails
  • Add test to ensure existing options behave as is :hyics

By implementing these tests, the aim is to provide comprehensive coverage of the admin:admin feature, validating its functionality under various scenarios and ensuring the reliability and security of the new Java tool.
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Nov 1, 2023
@DarshitChanpura DarshitChanpura mentioned this issue Nov 1, 2023
Closed
6 tasks
@DarshitChanpura DarshitChanpura changed the title [admin:admin] Implement tests for the admin:admin feature [DefaultAdminPassword] Implement tests for the admin:admin feature Nov 1, 2023
@DarshitChanpura DarshitChanpura changed the title [DefaultAdminPassword] Implement tests for the admin:admin feature Implement tests for the admin:admin feature Nov 1, 2023
@DarshitChanpura DarshitChanpura changed the title Implement tests for the admin:admin feature Implement tests to verify changes to default admin credentials Nov 2, 2023
@stephen-crawford
Copy link
Contributor

[Triage] @DarshitChanpura thanks for filing this issue. Great job breaking down the action items. Looks good to me.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 6, 2023
@DarshitChanpura DarshitChanpura self-assigned this Nov 15, 2023
@DarshitChanpura DarshitChanpura mentioned this issue Dec 7, 2023
Merged
2 tasks
stephen-crawford pushed a commit that referenced this issue Dec 13, 2023
@DarshitChanpura
Adds tests for demo configuration java tool (#3807)
e698315 
### Description
This PR adds tests associated with the demo-configuration tool.

## Issues Resolved:
 - Resolves #3636

### Testing
- Unit Testing
- Integration Testing

### Check List
- [x] New functionality includes testing
~- [ ] New functionality has been documented~
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura added a commit to DarshitChanpura/security that referenced this issue Dec 13, 2023
@DarshitChanpura
Adds tests for demo configuration java tool (opensearch-project#3807)
dc65ba5 
### Description
This PR adds tests associated with the demo-configuration tool.

## Issues Resolved:
 - Resolves opensearch-project#3636

### Testing
- Unit Testing
- Integration Testing

### Check List
- [x] New functionality includes testing
~- [ ] New functionality has been documented~
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Darshit Chanpura <[email protected]>
prabhask5 pushed a commit to prabhask5/opensearch-security that referenced this issue Jan 11, 2024
@DarshitChanpura @prabhask5
Adds tests for demo configuration java tool (opensearch-project#3807)
a57def3 
### Description
This PR adds tests associated with the demo-configuration tool.

## Issues Resolved:
 - Resolves opensearch-project#3636

### Testing
- Unit Testing
- Integration Testing

### Check List
- [x] New functionality includes testing
~- [ ] New functionality has been documented~
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
dlin2028 pushed a commit to dlin2028/security that referenced this issue May 1, 2024
@DarshitChanpura @dlin2028
Adds tests for demo configuration java tool (opensearch-project#3807)
d1cbe33 
### Description
This PR adds tests associated with the demo-configuration tool.

## Issues Resolved:
 - Resolves opensearch-project#3636

### Testing
- Unit Testing
- Integration Testing

### Check List
- [x] New functionality includes testing
~- [ ] New functionality has been documented~
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarshitChanpura DarshitChanpura

Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds tests for demo configuration java tool DarshitChanpura/security
2 participants
@DarshitChanpura @stephen-crawford