Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Onboard distribution level BWC bundle test #4005

Open
zelinh opened this issue Jan 30, 2024 · 5 comments
Open

[FEATURE] Onboard distribution level BWC bundle test #4005

zelinh opened this issue Jan 30, 2024 · 5 comments
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@zelinh
Copy link
Member

zelinh commented Jan 30, 2024

Currently security repo has BWC test on plugin level and only tested within the repo. We have a framework for BWC distribution level test available and you could utilize it and enable distribution level BWC test.

With this framework, you would be able to spin up the test cluster with the latest distribution bundle that engineering effectiveness team generated that installs all the other components. This test will be more comprehensive as it will test the exact product we ship to the customers.

Onboarding this distribution level BWC test can also enable engineering effectiveness team to run BWC tests every time ee team generates a new bundle distribution across each of the plugin through CI

More onboarding info can be found here:
https://github.com/opensearch-project/opensearch-plugins/blob/main/TESTING.md#bwc-tests-on-distribution-bundle-level

What solution would you like?
Similar to what we did to the anomaly-detection plugin. opensearch-project/anomaly-detection#766
Enable bundle level BWC test based on the BWC test you already have.

@zelinh zelinh added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 30, 2024
@stephen-crawford
Copy link
Contributor

[Triage] Hi @zelinh, thank you for filing this issue. Based on the linked campaign it seems like this is coming from a build team effort. Can we expect a build team member to be opening a pull request to make this change or are you looking for each repo to swap to the new framework themselves? We can close this issue when we have swapped over to the new framework so going to mark as triaged.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Feb 5, 2024
@zelinh zelinh added the v2.13.0 Issues targeting release v2.13.0 label Feb 27, 2024
@zelinh
Copy link
Member Author

zelinh commented Feb 27, 2024

Hi @scrawfor99, we are looking for each plugin team to onboard to this distribution level BWC tests since we have an existing framework for this. It's not swapping; currently the BWC tests most teams running are plugin level tests which was testing the plugin within cluster with only core and this particular plugin.

We want each team to onboard to this distribution level BWC tests framework as well so that we are testing in this case, security plugin with a whole bundle cluster.

@stephen-crawford
Copy link
Contributor

This is not going to be complete by 2.13 considering the lack of PR. I am removing the tag.

@stephen-crawford stephen-crawford removed the v2.13.0 Issues targeting release v2.13.0 label Mar 19, 2024
@zelinh
Copy link
Member Author

zelinh commented Jul 17, 2024

Can we get some traction on this issue? This BWC tests request would be a future release blocker.

@zelinh
Copy link
Member Author

zelinh commented Aug 14, 2024

@stephen-crawford Do we have a plan to onboard to this distribution level BWC test? We are planning to add BWC tests as mandatory exit criteria in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

2 participants