HeapBasedRateTracker uses time provider to allow simluating of time in unit tests #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in unit tests Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
cwperks
approved these changes
Jan 9, 2024
src/test/java/org/opensearch/security/auth/limiting/HeapBasedRateTrackerTest.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3934 +/- ##
==========================================
+ Coverage 65.16% 65.29% +0.12%
==========================================
Files 298 298
Lines 21218 21221 +3
Branches 3457 3457
==========================================
+ Hits 13827 13856 +29
+ Misses 5676 5649 -27
- Partials 1715 1716 +1
|
stephen-crawford
approved these changes
Jan 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…n unit tests (#3934) Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit 37d3ca2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willyborankin
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ating of time in unit tests (#3941) Backport 37d3ca2 from #3934. Signed-off-by: Peter Nied <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…n unit tests (opensearch-project#3934) Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HeapBasedRateTracker uses time provider to allow simluating of time in unit tests
Issues Resolved
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.