Update security analytics roles to include custom log type cluster permissions #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
- Coverage 65.42% 65.41% -0.01%
==========================================
Files 298 298
Lines 21219 21219
Branches 3457 3457
==========================================
- Hits 13883 13881 -2
- Misses 5616 5617 +1
- Partials 1720 1721 +1 |
willyborankin
approved these changes
Jan 16, 2024
goyamegh
approved these changes
Jan 16, 2024
peternied
approved these changes
Jan 16, 2024
peternied
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…rmissions (#3951) Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 7273936) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied
pushed a commit
that referenced
this pull request
Jan 17, 2024
…type cluster permissions (#3954) Backport 7273936 from #3951. Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…rmissions (opensearch-project#3951) Signed-off-by: Subhobrata Dey <[email protected]>
|
Hi can we backport this PR to 2.9 and 2.11 as well? We started supporting custom log types on these two versions |
DarshitChanpura
added
backport 2.9
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
…rmissions (#3951) Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 7273936) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
…rmissions (#3951) Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 7273936) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update security analytics roles with custom log type cluster permissions
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Security Analytics Role enhancement
Why these changes are required?
Custom Log Types were introduced in
2.10but they were only available foradminusers. This pr allowsnon-adminusers to access custom log types.Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.