Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The TO_SECONDS Function To The SQL Plugin #1419

Merged

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds the to_seconds function to the SQL plugin. Takes a DATE/TIME/DATETIME/TIMESTAMP/STRING/INTEGER representing a point in time, and converts it to seconds since the year 0. This function is based off of MySQL. For arguments of type TIME, the function takes the current date at the given time. For INTEGER, the integer is parsed as a date (e.g. 950501 == 1995-05-01).

Examples:
SELECT TO_SECONDS(950501); -> 62966505600
SELECT TO_SECONDS('2009-11-29'); -> 63426672000
SELECT TO_SECONDS('2009-11-29 13:43:32'); -> 63426721412

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test For Time Type

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Docs and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed DateTimeFormatter Priority

Signed-off-by: GabeFernandez310 <[email protected]>

* Added More Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Updated Docs

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation For Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleanup

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Implementation And Code Coverage

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed getFormatter Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Comments

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner March 9, 2023 22:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #1419 (b366b76) into main (cd95bc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1419   +/-   ##
=========================================
  Coverage     98.38%   98.39%           
- Complexity     3693     3711   +18     
=========================================
  Files           343      343           
  Lines          9107     9162   +55     
  Branches        585      588    +3     
=========================================
+ Hits           8960     9015   +55     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/utils/DateTimeFormatters.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

acarbonetto
acarbonetto previously approved these changes Mar 13, 2023
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: GabeFernandez310 <[email protected]>
@dai-chen dai-chen merged commit d38a6ec into opensearch-project:main Mar 16, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d38a6ec20d1ddc035adf53f610af05cfad812b6a
# Push it to GitHub
git push --set-upstream origin backport/backport-1419-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1419-to-2.x.

GabeFernandez310 added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 16, 2023
)

* Add The `TO_SECONDS` Function To The SQL Plugin (#232)

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test For Time Type

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Docs and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed DateTimeFormatter Priority

Signed-off-by: GabeFernandez310 <[email protected]>

* Added More Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Updated Docs

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation For Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleanup

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Implementation And Code Coverage

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed getFormatter Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Comments

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Code

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit d38a6ec)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 17, 2023
* Add The `TO_SECONDS` Function To The SQL Plugin (#232)

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test For Time Type

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Docs and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed DateTimeFormatter Priority

Signed-off-by: GabeFernandez310 <[email protected]>

* Added More Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Updated Docs

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation For Formatters

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleanup

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Implementation And Code Coverage

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed getFormatter Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Comments

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Code

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit d38a6ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants