-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pull_request_target events #52
Conversation
Hi @kadams54, Thank you for contributing and adding a new feature in the commitlint. We will quickly review the code and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
`pull_request` events don't have the necessary privileges to access private repos. Adding support for the `pull_request_target` event will allow private repos to also use commit lint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadams54 Thanks for your contribution. I've left a suggestion on the changes.
Co-authored-by: Sugat Bajracharya <[email protected]>
Description
pull_request
events don't have the necessary privileges to access private repos. Adding support for thepull_request_target
event will allow private repos to also use commit lint.Related Issue
[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.README.md
.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.