From d3c8945211f7fa5ef5949777608ce07b6438dc52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ott=C3=B3?= Date: Wed, 25 Sep 2024 11:47:54 -0500 Subject: [PATCH 1/2] changes to focusing and more --- tests/ui/pages/home.py | 5 +---- tests/ui/test_readme_validate_other_features.py | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/ui/pages/home.py b/tests/ui/pages/home.py index 3e07bb94..d55dc325 100644 --- a/tests/ui/pages/home.py +++ b/tests/ui/pages/home.py @@ -79,10 +79,6 @@ def push_message_input_field_is_visible(self): def push_message_input_field_not_visible(self): return self.page.locator("div.monaco-inputbox.idle") - @property - def push_content_dialog_box(self): - return self.page.locator("div > div.notifications-toasts.visible") - @property def generate_readme_button_is_visible(self): return self.page.get_by_text("Generate README", exact=True) @@ -279,6 +275,7 @@ def gitpod_menubar_locator(self): return self.page.locator("div.menubar-menu-button") def click_gitpod_menubar(self): + self.gitpod_menubar_locator.focus() self.gitpod_menubar_locator.click() @property diff --git a/tests/ui/test_readme_validate_other_features.py b/tests/ui/test_readme_validate_other_features.py index e0121275..e93db7ae 100644 --- a/tests/ui/test_readme_validate_other_features.py +++ b/tests/ui/test_readme_validate_other_features.py @@ -48,7 +48,6 @@ def test_readme_validate_other_features( home.click_push_content_button() assert home.push_message_input_field_is_visible - assert "Push Content: Pushing..." in home.push_content_dialog_box.inner_text() chrome_page.keyboard.press("Escape") assert home.push_message_input_field_not_visible From 7cd08819e1204c04379ec1a68e35b8fa063c0d8c Mon Sep 17 00:00:00 2001 From: Tyler Nullmeier Date: Wed, 25 Sep 2024 12:10:23 -0500 Subject: [PATCH 2/2] Use upload-artifact version 4 --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2f4981b9..2107af97 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -35,7 +35,7 @@ jobs: sed -Ei 's/("version": ")(.+)(",)$/\1\2-'$VERSION_VALUE'\3/' package.json npm run build:production - name: Upload Extension - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: editor-extension path: editor-*.vsix