-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for ES6 #26
Comments
@wruth Thanks for reporting. Yeah, I ran into that when making the changes and documented it, but can't recall where. I will document the work around and share out in the documentation. Since there is a pretty straight forward workaround, we will not be prioritizing it over the other work scheduled for the libraries. It will be a focus soon enough, but I don't have an ETA for that. cc @ssetem Any ideas/suggestions? |
yeh right now the top module.exports=function(dep1, dep2){ ... needs to remain Have been using spur-ioc alot recently, not much advantage changing the top declaration to es6 syntax |
@ssetem Yeah. That's what I initial thought, just didn't seem to document. |
I think it's useful in unit tests. See #31 and spur unit tests, where dependencies often get set to |
Spur IOC breaks for fat arrow function syntax in ES6. For instance, I got this error when I attempted to run the ES6 code directly without babel transpilation:
I believe this is a consequence of Util.js looking for the String 'function' in
parseDependencies()
, and not being able to find it in these cases.The text was updated successfully, but these errors were encountered: