Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WAF] Add possibility to change TLS config #1132

Merged
merged 4 commits into from
Jun 18, 2021
Merged

[WAF] Add possibility to change TLS config #1132

merged 4 commits into from
Jun 18, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Jun 18, 2021

Summary of the Pull Request

Add possibility to change TLS config in `resource/opentelekomcloud_waf_domain_v``
Resolves: #1092

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccWafDomainV1Basic
--- PASS: TestAccWafDomainV1Basic (78.20s)
PASS

Process finished with the exit code 0

@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team June 18, 2021 12:18
otc-zuul[bot]
otc-zuul bot previously approved these changes Jun 18, 2021
View reviewed changes
outcatcher
outcatcher suggested changes Jun 18, 2021
View reviewed changes
opentelekomcloud/services/waf/resource_opentelekomcloud_waf_domain_v1.go Outdated
Comment on lines 95 to 97
// ValidateFunc: validation.StringInSlice([]string{
// "cipher_default", "cipher_1", "cipher_2", "cipher_3",
// }, false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused code

@lego963 lego963 dismissed stale reviews from anton-sidelnikov and otc-zuul[bot] via 30494e4 June 18, 2021 12:52
@lego963 lego963 added the gate Merge PR label Jun 18, 2021
@otc-zuul
Copy link

otc-zuul bot commented Jun 18, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 2d26f0d into devel Jun 18, 2021
@otc-zuul otc-zuul bot deleted the waf-tls branch June 18, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov left review comments

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way for configuring the WAF TLS settings
3 participants
@lego963 @outcatcher @anton-sidelnikov