Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor r/obs_bucket_object #781

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Refactor r/obs_bucket_object #781

merged 1 commit into from
Dec 23, 2020

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Dec 22, 2020 •
edited
Loading

Summary of the Pull Request

Remove code duplications
Remove unused credentials argument
Minor refactoring

PR Checklist

  • Tests added/passed.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccObsBucketObject_source
--- PASS: TestAccObsBucketObject_source (42.77s)
=== RUN   TestAccObsBucketObject_content
--- PASS: TestAccObsBucketObject_content (23.45s)
=== RUN   TestAccObsBucketObject_nothing
--- PASS: TestAccObsBucketObject_nothing (0.07s)
PASS

Process finished with exit code 0

@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team December 22, 2020 16:53
@outcatcher outcatcher marked this pull request as ready for review December 22, 2020 16:54
otc-zuul[bot]
otc-zuul bot previously approved these changes Dec 22, 2020
View reviewed changes
@outcatcher
Refactor r/obs_bucket_object
4d9ca7c 
Remove code duplications

Remove unused `credentials` argument

Minor refactoring
@outcatcher outcatcher force-pushed the refactor/obs-bucket-object branch from eb0eb2d to 4d9ca7c Compare December 23, 2020 07:44
@outcatcher outcatcher added the gate Merge PR label Dec 23, 2020
@otc-zuul
Copy link

otc-zuul bot commented Dec 23, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 188049f into master Dec 23, 2020
@otc-zuul otc-zuul bot deleted the refactor/obs-bucket-object branch December 23, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outcatcher @lego963 @anton-sidelnikov