Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracedSubscriber changes threading #13

Open
randallt opened this issue May 17, 2021 · 1 comment
Open

TracedSubscriber changes threading #13

randallt opened this issue May 17, 2021 · 1 comment

Comments

@randallt
Copy link

Hi,

We ran into an issue where the Java SpecialAgent broke a Reactor application. Apparently the application is using a block() call (we know this is probably an anti-pattern and are looking to fix it) that works fine using the FluxElapsed.ElapsedSubscriber, but fails when the TracedSubscriber wrapper is added.

It looks like this is due to the fact that the threading can change since TracedSubscriber implements the SpanSubscription interface which always returns Fuseable.NONE for Fuseable.QueueSubscription.requestFusion.

Would it be possible to preserve the fusion mode from the wrapped subscriber instead of always returning NONE?

@jam01
Copy link
Collaborator

jam01 commented Jun 7, 2021

I'm not entirely sure. I've been removed from reactor for a couple of years now. If there's a PR you'd like to submit I'd be happy to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants