Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Add discrete events #145

Open
daniel-white opened this issue Sep 19, 2019 · 1 comment
Open

Add discrete events #145

daniel-white opened this issue Sep 19, 2019 · 1 comment

Comments

@daniel-white
Copy link

daniel-white commented Sep 19, 2019

Background

Sometimes it is advantageous to capture discrete events as a single point in time, not over a duration.

Problem

Currently the specification doesn't seem to have any way of reporting a single point in time event. A log doesn't quite make sense to display all of them on a flame graph.

Proposal

I propose that a discrete API be added. This would allow applications to report a point in time event. These could be added as flags on a flame chart similar to Visual Studio's Diagnostic tools (https://devblogs.microsoft.com/visualstudio/analyze-cpu-memory-while-debugging/)

Various implementations could add customization points as to what kind of flag should be shown.

Questions to address

  • How will current implementations add this to avoid breaking changes?
@yurishkuro
Copy link
Member

Point-in-time events can be captured via span.log() today, but they lack causality links between them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants