Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Rename DynamicBufferModule to DynamicBufferMixin #1649

Closed
djdameln opened this issue Jan 17, 2024 · 5 comments
Closed

🔨 Rename DynamicBufferModule to DynamicBufferMixin #1649

djdameln opened this issue Jan 17, 2024 · 5 comments
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Refactor Refactoring is needed

Comments

@djdameln
Copy link
Contributor

What is the motivation for this task?

The DynamicBufferModule class, which is used to allow dynamically changing the shape of tensors registered as buffers, essentially behaves as a mixin and should be named as such.

Describe the solution you'd like

Rename DynamicBufferModule to DynamicBufferMixin.

Additional context

We could consider moving the mixins to their own submodule under models.components
@djdameln djdameln added the Task label Jan 17, 2024
@djdameln djdameln self-assigned this Jan 17, 2024
@djdameln
Copy link
Contributor Author

also add some unit tests

@djdameln djdameln mentioned this issue Jan 22, 2024
Merged
5 tasks
@samet-akcay samet-akcay changed the title [Task]: Rename DynamicBufferModule to DynamicBufferMixin 🔨 Rename DynamicBufferModule to DynamicBufferMixin Feb 9, 2024
@samet-akcay samet-akcay added Refactor Refactoring is needed and removed Task labels Feb 9, 2024
@samet-akcay samet-akcay added the Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. label Feb 26, 2024
@danylo-boiko danylo-boiko mentioned this issue Feb 27, 2024
Merged
9 tasks
@kamlesh-ops
Copy link

kamlesh-ops commented Feb 27, 2024 •
edited
Loading

Hii @samet-akcay @djdameln
I would like to take up this issue.
Also, I would love to know get any advice and insights from your side before starting.
Thanks:)

@samet-akcay
Copy link
Contributor

Hi @kamlesh-ops, @danylo-boiko just created PR #1776 to address this issue

@kamlesh-ops
Copy link

Ohh no problem. @samet-akcay
Btw let me know if I can still contribute in any way. I'll be looking for other issues till then
cheers:)

@samet-akcay
Copy link
Contributor

sure, thanks for your interest. There are bunch of Good First Issues there. I'll continue to label more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Refactor Refactoring is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ashwinvaidya17 @samet-akcay @djdameln @kamlesh-ops