From c2c223b877ec5d20795e5908bb08064ec246f13a Mon Sep 17 00:00:00 2001 From: Manideep-Kanna Date: Sun, 1 Dec 2024 09:43:47 +0530 Subject: [PATCH 1/3] Added condition and test case --- src/bindings/js/node/src/tensor.cpp | 6 ++++++ src/bindings/js/node/tests/unit/tensor.test.js | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/src/bindings/js/node/src/tensor.cpp b/src/bindings/js/node/src/tensor.cpp index 78785a10b2275b..5234c620820a15 100644 --- a/src/bindings/js/node/src/tensor.cpp +++ b/src/bindings/js/node/src/tensor.cpp @@ -66,6 +66,12 @@ Napi::Object TensorWrap::wrap(Napi::Env env, ov::Tensor tensor) { } Napi::Value TensorWrap::get_data(const Napi::CallbackInfo& info) { + Napi::Env env = info.Env(); + if (info.Length() > 0) { + reportError(env, "getData() does not accept any arguments."); + return env.Undefind + } + auto type = _tensor.get_element_type(); switch (type) { diff --git a/src/bindings/js/node/tests/unit/tensor.test.js b/src/bindings/js/node/tests/unit/tensor.test.js index 656bdf9b122e58..2cd5115b5af2a8 100644 --- a/src/bindings/js/node/tests/unit/tensor.test.js +++ b/src/bindings/js/node/tests/unit/tensor.test.js @@ -121,6 +121,12 @@ describe('ov.Tensor tests', () => { assert.deepStrictEqual(tensor.getData(), data); }); + it('getData should throw an error if arguments are provided', () => { + const tensor = new ov.Tensor(ov.element.f32, shape, data); + assert.throws(() => tensor.getData(1), { + message: 'getData() does not accept any arguments.', + }); + }); it('test tensor.data setter - different element type throws', () => { const float64Data = Float64Array.from([1, 2, 3]); const tensor = new ov.Tensor(ov.element.f32, [1, 3]); From 30554a95ba6a5047683054a68a92384b1a5fc880 Mon Sep 17 00:00:00 2001 From: Manideep-Kanna Date: Mon, 2 Dec 2024 17:31:41 +0530 Subject: [PATCH 2/3] Added proper function --- src/bindings/js/node/src/tensor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bindings/js/node/src/tensor.cpp b/src/bindings/js/node/src/tensor.cpp index 5234c620820a15..0c672c72704ad6 100644 --- a/src/bindings/js/node/src/tensor.cpp +++ b/src/bindings/js/node/src/tensor.cpp @@ -69,7 +69,7 @@ Napi::Value TensorWrap::get_data(const Napi::CallbackInfo& info) { Napi::Env env = info.Env(); if (info.Length() > 0) { reportError(env, "getData() does not accept any arguments."); - return env.Undefind + return env.Undefined() } auto type = _tensor.get_element_type(); From 32834a3210a887bf342248eed72173706522f46a Mon Sep 17 00:00:00 2001 From: Manideep-Kanna Date: Tue, 3 Dec 2024 16:10:43 +0530 Subject: [PATCH 3/3] Added semicolon --- src/bindings/js/node/src/tensor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bindings/js/node/src/tensor.cpp b/src/bindings/js/node/src/tensor.cpp index 0c672c72704ad6..14a68286e5372c 100644 --- a/src/bindings/js/node/src/tensor.cpp +++ b/src/bindings/js/node/src/tensor.cpp @@ -69,7 +69,7 @@ Napi::Value TensorWrap::get_data(const Napi::CallbackInfo& info) { Napi::Env env = info.Env(); if (info.Length() > 0) { reportError(env, "getData() does not accept any arguments."); - return env.Undefined() + return env.Undefined(); } auto type = _tensor.get_element_type();