Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert metric analysis scripts into rust crate #1030

Closed
jonathanpwang opened this issue Dec 13, 2024 · 3 comments · Fixed by #1148
Closed

Convert metric analysis scripts into rust crate #1030

jonathanpwang opened this issue Dec 13, 2024 · 3 comments · Fixed by #1148
Assignees
Labels
enhancement New feature or request

Comments

@jonathanpwang
Copy link
Contributor

Currently the post-processing on the collected metrics from the prover can processed using python scripts in ci/scripts/metrics_unify/. These are used to generate a markdown report and flamegraphs of cell/instruction usage. To keep everything in Rust and also to make it easier to import these tools in other repos, we should convert all the scripts into a Rust crate.

@jonathanpwang jonathanpwang added the enhancement New feature or request label Dec 13, 2024
@keroro520
Copy link
Contributor

Would you mind to assign this issue to me? @jonathanpwang

@jonathanpwang
Copy link
Contributor Author

Assigned, but noting that I am updating our metrics collection and will be making a first pass at porting over the summarize.py because we need it for benchmark analysis

@jonathanpwang
Copy link
Contributor Author

@keroro520 to avoid overlap, you can start with the fine-grained metric collection (corresponding to metrics_unify/main.py). I will be focusing on summarize.py and flamegraph.py.

Separate from this, I would be interested in a standalone prometheus recorder for metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants