-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate JWT signed other implemenation #158
Merged
cre8
merged 8 commits into
openwallet-foundation:next
from
lukasjhan:feat/fix-jwt-validate
Mar 11, 2024
Merged
fix: validate JWT signed other implemenation #158
cre8
merged 8 commits into
openwallet-foundation:next
from
lukasjhan:feat/fix-jwt-validate
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas.J.Han <[email protected]>
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
March 11, 2024 13:29
Signed-off-by: Lukas.J.Han <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #158 +/- ##
==========================================
+ Coverage 97.81% 98.03% +0.21%
==========================================
Files 23 23
Lines 2062 2082 +20
Branches 295 307 +12
==========================================
+ Hits 2017 2041 +24
+ Misses 45 41 -4 ☔ View full report in Codecov by Sentry. |
cre8
approved these changes
Mar 11, 2024
@lukasjhan code looks good, can you add missing tests before merging? |
Okay :) I'm working on it |
Signed-off-by: Lukas.J.Han <[email protected]>
|
Signed-off-by: Lukas.J.Han <[email protected]>
There is a token. It's strange. We're trying to find out why. |
Signed-off-by: Lukas.J.Han <[email protected]>
This reverts commit e972619. Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
cre8
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Lukas.J.Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added private field in JWT class. It is set when we created JWT instance from encoded.
And I created getUnsignedToken method to use encoded jwt string when it is existed.
It close #157