-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem report is sent when no exchange exists yet #1730
Comments
That's funny... :-). |
While funny, we should prevent this -- having a protocol initiator reporting a problem to another agent before the protocol has started. It would be good to have someone look into this. First, we need to look at this in this specific case -- issue credential protocol (v1 and presumably v2). How do we prevent a problem report from the initiator going out before the first message of the protocol has been sent? Second, what other protocols are susceptible to this issue? Is there a cross-cutting mechanism that can be applied to handle this, or does each protocol have to be updated? |
Reply to @swcurran Re: Second, what other protocols are susceptible to this issue? @TimoGlastra This issue should be fixed by PR #2519. Can you please verify and close this issue if that is the case. |
When sending a credential offer in v1 and creating a bad request (in my case I made a type in one of the attribute names) ACA-Py will send a problem report to the other agent without having initiated the protocol.
Not sure if other endpoints / protocols are affected, but I find it an quite amusing issue :)
The text was updated successfully, but these errors were encountered: