Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message mishandled when return route decorator is used for recipient with routing enabled #198

Closed
swcurran opened this issue Sep 25, 2019 · 2 comments · Fixed by #199
Closed
Labels
bug Something isn't working

Comments

@swcurran
Copy link
Contributor

This issue was found by @mickrau.

An ACA-Py agent has been given a DIDDoc from a mobile agent that has both a recipientKey and a routingKey. When a message is sent by the ACA-Py agent to the mobile agent via that route, the message is properly wrapped as a forward to the routing agent, who then gets the forwarded message to the mobile agent. All good.

However, when the mobile agent sends a message directly to the ACA-Py agent and includes a transport return route decorator, the ACA-Py agent prepares the message as a forward for the routing agent, but sends the message directly to the mobile agent via the HTTP response. That doesn't work - the mobile agent cannot process the forward.

Please fix ACA-Py. One of two things needs to change:

  1. Ignore the return route when there is a routing agent needed, or
  2. Don't wrap the message with any forwards if the return route is to be used.

Obviously 2 is the much better answer, although the 1st one could work for the short term.

This is an issue for many mobile agent to enterprise agent scenarios, so please look into this pretty quickly.

@swcurran
Copy link
Contributor Author

@mickrau - this has been fixed and is in master right now. Are you able to test this?

@mickrau
Copy link

mickrau commented Oct 2, 2019

I can confirm that this bug is fixed in version 0.3.3.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants