Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: revisit tail file deletion tests #2568

Open
dbluhm opened this issue Oct 27, 2023 · 0 comments
Open

tests: revisit tail file deletion tests #2568

dbluhm opened this issue Oct 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dbluhm
Copy link
Contributor

dbluhm commented Oct 27, 2023

While working on #2566, I discovered that there are some tests that need attention in aries_cloudagent/revocation/tests/test_routes.py in the TestDeleteTails test case. These tests were not being run (despite the appearance of being run) due to a mistake made in the test class definition: unittest.TestCase instead of asynctest's TestCase was used. As a result, there seems to be some dubious test code. Not dubious in the malicious sense, just unlikely to have ever been in a working state.

We should revisit these tests.

@dbluhm dbluhm added the bug Something isn't working label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant