Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present proof problem report handler throws exception for OOB proof requests #3069

Closed
loneil opened this issue Jun 25, 2024 · 2 comments
Closed

Comments

@loneil
Copy link
Contributor

loneil commented Jun 25, 2024

When an abandoned state triggers on a 2.0 proof (in our BC Gov VCAuth-N ecosystem implementation, when a user declines the proof in their wallet) it invokes the V20PresProblemReportHandler. But if this is an OOB proof request with no connection an unhandled exception happens due to context.connection_record.connection_id

This was addressed for the 1.0 protocol here #2723 but I think should be added for the equivalent problem report handler for 2.0

Error:

2024-06-25 15:08:19 2024-06-25 22:08:19,935 aries_cloudagent.core.conductor ERROR Exception in message handler:
2024-06-25 15:08:19 Traceback (most recent call last):
2024-06-25 15:08:19   File "/usr/local/lib/python3.9/asyncio/tasks.py", line 256, in __step
2024-06-25 15:08:19     result = coro.send(None)
2024-06-25 15:08:19   File "/home/aries/.local/lib/python3.9/site-packages/aries_cloudagent/core/dispatcher.py", line 210, in handle_message
2024-06-25 15:08:19     await handler(context, responder)
2024-06-25 15:08:19   File "/home/aries/.local/lib/python3.9/site-packages/aries_cloudagent/protocols/present_proof/v2_0/handlers/pres_problem_report_handler.py", line 32, in handle
2024-06-25 15:08:19     context.connection_record.connection_id,
2024-06-25 15:08:19 AttributeError: 'NoneType' object has no attribute 'connection_id'
2024-06-25 15:08:19 2024-06-25 22:08:19,936 aries_cloudagent.core.conductor ERROR DON'T shutdown on AttributeError 'NoneType' object has no attribute 'connection_id'
2024-06-25 15:08:19 2024-06-25 22:08:19,936 aries_cloudagent.core.dispatcher ERROR Handler error: Dispatcher.handle_message
2024-06-25 15:08:19 Traceback (most recent call last):
2024-06-25 15:08:19   File "/usr/local/lib/python3.9/asyncio/tasks.py", line 256, in __step
2024-06-25 15:08:19     result = coro.send(None)
2024-06-25 15:08:19   File "/home/aries/.local/lib/python3.9/site-packages/aries_cloudagent/core/dispatcher.py", line 210, in handle_message
2024-06-25 15:08:19     await handler(context, responder)
2024-06-25 15:08:19   File "/home/aries/.local/lib/python3.9/site-packages/aries_cloudagent/protocols/present_proof/v2_0/handlers/pres_problem_report_handler.py", line 32, in handle
2024-06-25 15:08:19     context.connection_record.connection_id,
2024-06-25 15:08:19 AttributeError: 'NoneType' object has no attribute 'connection_id'
@loneil
Copy link
Contributor Author

loneil commented Jun 25, 2024

Addressed here #3068

@loneil
Copy link
Contributor Author

loneil commented Jun 25, 2024

@Gavinok @esune as discussed the issue with VCAuth-N erroring on decline with 2.0 proofs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants