Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with JSON-LD specific data #256

Closed
TimoGlastra opened this issue Jun 14, 2021 · 7 comments
Closed

Add tests with JSON-LD specific data #256

TimoGlastra opened this issue Jun 14, 2021 · 7 comments

Comments

@TimoGlastra
Copy link
Contributor

Current Issue Credential (and Present Proof tests I'm working on now) make use of the same custom drivers license schema used for indy tests. I think it will be good to add tests (credential and proof data) specific to JSON-LD credentials that leverages the public available contexts.

Some contexts we could use:

@ianco
Copy link
Contributor

ianco commented Jun 14, 2021

FYI I'm updating the alice/faber demo to use the Citizenship vocab to support json-ld credentials and proofs, and will also be adding this to the aca-py integration tests.

@TimoGlastra
Copy link
Contributor Author

Awesome. Do you already have some example documents I can re-use?

@ianco
Copy link
Contributor

ianco commented Jun 14, 2021

Awesome. Do you already have some example documents I can re-use?

Work in progress is on this draft PR: openwallet-foundation/acapy#1235

I've added a more detailed tutorial document (wip) to provide some more detailed cred/proof examples:

https://github.com/hyperledger/aries-cloudagent-python/pull/1235/files#diff-5a4a5e5fa63814bb4f57173307b734dbaa0742849534bb5a8219de1f90ce8e7e

@TimoGlastra
Copy link
Contributor Author

Nice.

I see you also have an example with the vaccination vocab. It's not working ATM in ACA-Py, I'm running into an issue with compaction: w3c-ccg/vaccination-vocab#22

@ianco
Copy link
Contributor

ianco commented Jun 14, 2021

Nice.

I see you also have an example with the vaccination vocab. It's not working ATM in ACA-Py, I'm running into an issue with compaction: w3c-ccg/vaccination-vocab#22

Right, I don't have this example working yet either, it's on my to-do list once I finish updating the alice/faber/bdd with the citizenship example.

@TimoGlastra
Copy link
Contributor Author

@ianco openwallet-foundation/acapy#1252 should fix the issues with vaccination vocab

@swcurran
Copy link
Contributor

Closing -- I think we are good with the samples we have today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants