Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Make batch import atomic #551

Open
nemesifier opened this issue Sep 13, 2024 · 1 comment
Open

[change] Make batch import atomic #551

nemesifier opened this issue Sep 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nemesifier
Copy link
Member

I was reviewing the batch CSV import code due to #550 and it seems to me the create operation is not atomic.

What if the import operation fails in the middle?

I believe we would end up with half users created.

I think it's better to make everything run in a transaction and if anything fails rollback.

@shwetd19
Copy link

Hey @nemesifier , I'm Shwetas, I am a final-year BTech-CSE student. I have strong experience in Java, JavaScript, and the Full-Stack. I’ve worked on open-source projects and built SaaS platforms, and I believe I can contribute effectively to this project. I would be grateful for the opportunity to be assigned to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do (general)
Development

No branches or pull requests

2 participants